-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[Doc][KubeRay] Remove very old ResNet benchmark example #53839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request removes a very old ResNet benchmark example and its related files from the documentation.
- Removed the outdated GPU training example markdown file.
- Removed the corresponding reference in the examples list.
- Deleted the outdated RayCluster GPU configuration and its associated Python job submission script.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
doc/source/cluster/kubernetes/examples/gpu-training-example.md | Removed the entire GPU training example documentation. |
doc/source/cluster/kubernetes/examples.md | Removed reference to the deleted GPU training example. |
doc/source/cluster/kubernetes/configs/ray-cluster.gpu.yaml | Deleted the outdated RayCluster configuration for the GPU example. |
doc/source/cluster/doc_code/pytorch_training_e2e_submit.py | Deleted the Python job submission script for the removed training benchmark. |
cc @jjyao would you mind merging this PR? |
Could you link the similar examples in the PR description? cc @dayshah for doc approval. |
Done |
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
The example still uses Ray 2.2. It is pretty old and KubeRay has already had other similar examples (ex: https://docs.ray.io/en/latest/cluster/kubernetes/examples/mnist-training-example.html#kuberay-mnist-training-example). Remove it from the doc. Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
…53839) The example still uses Ray 2.2. It is pretty old and KubeRay has already had other similar examples (ex: https://docs.ray.io/en/latest/cluster/kubernetes/examples/mnist-training-example.html#kuberay-mnist-training-example). Remove it from the doc. Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
The example still uses Ray 2.2. It is pretty old and KubeRay has already had other similar examples (ex: https://docs.ray.io/en/latest/cluster/kubernetes/examples/mnist-training-example.html#kuberay-mnist-training-example). Remove it from the doc. Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Why are these changes needed?
The example still uses Ray 2.2. It is pretty old and KubeRay has already had other similar examples (ex: https://docs.ray.io/en/latest/cluster/kubernetes/examples/mnist-training-example.html#kuberay-mnist-training-example). Remove it from the doc.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.