Skip to content

[Doc][KubeRay] Remove very old ResNet benchmark example #53839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Jun 15, 2025

Why are these changes needed?

The example still uses Ray 2.2. It is pretty old and KubeRay has already had other similar examples (ex: https://docs.ray.io/en/latest/cluster/kubernetes/examples/mnist-training-example.html#kuberay-mnist-training-example). Remove it from the doc.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
@kevin85421 kevin85421 changed the title [Doc][KubeRay] [Doc][KubeRay] Remove very old ResNet benchmark example Jun 15, 2025
@kevin85421 kevin85421 added the go add ONLY when ready to merge, run all tests label Jun 15, 2025
@kevin85421 kevin85421 marked this pull request as ready for review June 16, 2025 04:51
@Copilot Copilot AI review requested due to automatic review settings June 16, 2025 04:51
@kevin85421 kevin85421 requested review from pcmoritz and a team as code owners June 16, 2025 04:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes a very old ResNet benchmark example and its related files from the documentation.

  • Removed the outdated GPU training example markdown file.
  • Removed the corresponding reference in the examples list.
  • Deleted the outdated RayCluster GPU configuration and its associated Python job submission script.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
doc/source/cluster/kubernetes/examples/gpu-training-example.md Removed the entire GPU training example documentation.
doc/source/cluster/kubernetes/examples.md Removed reference to the deleted GPU training example.
doc/source/cluster/kubernetes/configs/ray-cluster.gpu.yaml Deleted the outdated RayCluster configuration for the GPU example.
doc/source/cluster/doc_code/pytorch_training_e2e_submit.py Deleted the Python job submission script for the removed training benchmark.

@kevin85421
Copy link
Member Author

cc @jjyao would you mind merging this PR?

@jjyao
Copy link
Collaborator

jjyao commented Jun 16, 2025

It is pretty old and KubeRay has already had other similar examples.

Could you link the similar examples in the PR description?

cc @dayshah for doc approval.

@kevin85421
Copy link
Member Author

Could you link the similar examples in the PR description?

Done

Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
@kevin85421
Copy link
Member Author

cc @jjyao @edoakes would you mind merging this PR? Thanks!

@edoakes edoakes merged commit 6df958e into master Jun 16, 2025
5 checks passed
@edoakes edoakes deleted the laptop-ray3-20250615 branch June 16, 2025 20:50
elliot-barn pushed a commit that referenced this pull request Jun 18, 2025
The example still uses Ray 2.2. It is pretty old and KubeRay has already
had other similar examples (ex:
https://docs.ray.io/en/latest/cluster/kubernetes/examples/mnist-training-example.html#kuberay-mnist-training-example).
Remove it from the doc.

Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
minerharry pushed a commit to minerharry/ray that referenced this pull request Jun 27, 2025
…53839)

The example still uses Ray 2.2. It is pretty old and KubeRay has already
had other similar examples (ex:
https://docs.ray.io/en/latest/cluster/kubernetes/examples/mnist-training-example.html#kuberay-mnist-training-example).
Remove it from the doc.

Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
The example still uses Ray 2.2. It is pretty old and KubeRay has already
had other similar examples (ex:
https://docs.ray.io/en/latest/cluster/kubernetes/examples/mnist-training-example.html#kuberay-mnist-training-example).
Remove it from the doc.

Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants