-
Notifications
You must be signed in to change notification settings - Fork 6.5k
[KubeRay] Remove unused YAMLs #53840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Removes three deprecated Kubernetes YAML configurations from the docs that are no longer used after the recent refactoring.
- Delete unused fault-tolerance config
- Delete unused network-policy config
- Delete unused migration example
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
doc/source/cluster/kubernetes/configs/static-ray-cluster.with-fault-tolerance.yaml | Remove unused Redis fault-tolerance YAML |
doc/source/cluster/kubernetes/configs/static-ray-cluster-networkpolicy.yaml | Remove unused network policy YAML |
doc/source/cluster/kubernetes/configs/migration-example.yaml | Remove unused RayCluster migration example YAML |
Comments suppressed due to low confidence (3)
doc/source/cluster/kubernetes/configs/static-ray-cluster.with-fault-tolerance.yaml:1
- Ensure that all references to
static-ray-cluster.with-fault-tolerance.yaml
are removed or updated in the documentation to avoid broken links or stale examples.
-# This section is only required for deploying Redis on Kubernetes for the purpose of enabling Ray
doc/source/cluster/kubernetes/configs/static-ray-cluster-networkpolicy.yaml:1
- Check for any documentation pages or CI scripts that reference
static-ray-cluster-networkpolicy.yaml
and remove or update those links.
-# If your Kubernetes has a default deny network policy for pods, you need to manually apply this network policy
doc/source/cluster/kubernetes/configs/migration-example.yaml:1
- Verify that the migration example isn’t referenced elsewhere in the docs or examples directory, and remove any residual pointers to this file.
-apiVersion: ray.io/v1alpha1
cc @jjyao would you mind merging this PR? Thanks! |
cc @dayshah for code approval. |
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: Scott Lee <scott.lee@rebellions.ai>
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Why are these changes needed?
After #53833,
doc/source/cluster/kubernetes/configs/static-ray-cluster-networkpolicy.yaml
anddoc/source/cluster/kubernetes/configs/static-ray-cluster.with-fault-tolerance.yaml
are no longer used.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.