-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[Doc][KubeRay] Add a doc for scheduler plugins #53846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc][KubeRay] Add a doc for scheduler plugins #53846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc build failed. You need to add this doc to toctree.
doc/source/cluster/kubernetes/k8s-ecosystem/scheduler-plugins.md
Outdated
Show resolved
Hide resolved
|
||
Note that there are two modes for installing the scheduler plugins: **single scheduler mode** or **second scheduler mode**. | ||
|
||
For KubeRay v1.4.0, KubeRay only supports the **single scheduler mode**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you already tried both modes and confirmed that it only works with the single scheduler mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried the second scheduler mode. I am referring to https://scheduler-plugins.sigs.k8s.io/docs/user-guide/installation/:

I can give it a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work with the second scheduler although Step 4 is the same.
I tried to deploy a RayCluster with 1 CPU for the head Pod and 1000 CPUs for the worker Pods. The head Pod will still be scheduled when gang scheduling is enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from technical side. Waiting for doc team's approval.
cc @dayshah would you mind approving this PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some style nits. Thank you for contributing to docs.
doc/source/cluster/kubernetes/k8s-ecosystem/scheduler-plugins.md
Outdated
Show resolved
Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/scheduler-plugins.md
Outdated
Show resolved
Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/scheduler-plugins.md
Outdated
Show resolved
Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/scheduler-plugins.md
Outdated
Show resolved
Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/scheduler-plugins.md
Outdated
Show resolved
Hide resolved
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Thanks @MortalHappiness @angelinalg for the review! |
Signed-off-by: kaihsun <kaihsun@anyscale.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: kaihsun <kaihsun@anyscale.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Why are these changes needed?
Add a doc for scheduler plugins
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.