[core] Fix test_object_spilling.py on Windows
#53851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
israbbani
approved these changes
Jun 16, 2025
Comment on lines
+755
to
+756
| for obj_ref in [f.remote() for _ in range(5)]: | ||
| ray.get(obj_ref) |
There was a problem hiding this comment.
This is bizarre. I would expect
ray.get([f.remote() for _ in range(5)])
to have better performance since it's fetching a batch instead of blocking on each individual call.
There was a problem hiding this comment.
in this case I think it's more stressful because not all 5 objs fit in the object store
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
I made the workload more stressful in #53803 by fetching all of the results concurrently. That seems to have caused Windows to time out: https://buildkite.com/ray-project/postmerge/builds/10876#01977755-755b-485e-bd13-f0ea3e33cc36/158-818 I won't pretend to fully understand why, but reverting to the old pattern in an attempt to fix it. Also added an explicit wait for the dir to drain because there was an error during cleanup caused by it. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
I made the workload more stressful in ray-project#53803 by fetching all of the results concurrently. That seems to have caused Windows to time out: https://buildkite.com/ray-project/postmerge/builds/10876#01977755-755b-485e-bd13-f0ea3e33cc36/158-818 I won't pretend to fully understand why, but reverting to the old pattern in an attempt to fix it. Also added an explicit wait for the dir to drain because there was an error during cleanup caused by it. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
I made the workload more stressful in #53803 by fetching all of the results concurrently. That seems to have caused Windows to time out: https://buildkite.com/ray-project/postmerge/builds/10876#01977755-755b-485e-bd13-f0ea3e33cc36/158-818 I won't pretend to fully understand why, but reverting to the old pattern in an attempt to fix it. Also added an explicit wait for the dir to drain because there was an error during cleanup caused by it. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the workload more stressful in #53803 by fetching all of the results concurrently. That seems to have caused Windows to time out: https://buildkite.com/ray-project/postmerge/builds/10876#01977755-755b-485e-bd13-f0ea3e33cc36/158-818
I won't pretend to fully understand why, but reverting to the old pattern in an attempt to fix it.
Also added an explicit wait for the dir to drain because there was an error during cleanup caused by it.