[release] Fix release tests #53855
Merged
[release] Fix release tests #53855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses failing release tests by resolving a merge conflict that resulted in a missing parameter.
- Added a new optional "image" parameter to the run_release_test function.
- Forwarded the new "image" parameter to the run_release_test_kuberay call.
| @@ -407,6 +408,7 @@ def run_release_test( | |||
| no_terminate=no_terminate, | |||
| test_definition_root=test_definition_root, | |||
| log_streaming_limit=log_streaming_limit, | |||
| image=image, | |||
There was a problem hiding this comment.
run_release_test_kuberay does not currently accept an 'image' parameter. Update its signature to include 'image: Optional[str] = None' or remove the parameter from the call if not needed.
Copilot uses AI. Check for mistakes.
aslonnie
approved these changes
Jun 16, 2025
|
Ran test to confirm fix: https://buildkite.com/ray-project/release/builds/45763#01977a02-305c-41fc-be4d-681913679e39 |
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
Release tests seem to be failing because of a merge conflict on master after #53390 was merged where a param is missing Signed-off-by: kevin <kevin@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
Release tests seem to be failing because of a merge conflict on master after ray-project#53390 was merged where a param is missing Signed-off-by: kevin <kevin@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
Release tests seem to be failing because of a merge conflict on master after #53390 was merged where a param is missing Signed-off-by: kevin <kevin@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release tests seem to be failing because of a merge conflict on master after #53390 was merged where a param is missing