[core] adding additional stats to the dump object store usage api. #53856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding stats about spilling, sealed objects, and bytes used instead of just LRU stats to the output. - Adding documentation to the CoreWorker API in .pyx and .pxd files. - Returning a Status instead of an unhandled exception. Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
israbbani
commented
Jun 26, 2025
| @@ -2843,12 +2843,11 @@ def get( | |||
| "'object_refs' must either be an ObjectRef or a list of ObjectRefs. " | |||
| ) | |||
|
|
|||
| # TODO(ujvl): Consider how to allow user to retrieve the ready objects. | |||
There was a problem hiding this comment.
This is from 6 years ago. I think it's safe to delete it.
github-actions
bot
added
the
stale
israbbani
removed
the
stale
Signed-off-by: irabbani <irabbani@anyscale.com>
israbbani
commented
Jul 15, 2025
Comment on lines
+3599
to
+3604
| """Logs the current usage of the Plasma Store. | ||
| Makes an unretriable blocking IPC to the Plasma Store. | ||
|
|
||
| Raises an error if cannot connect to the Plasma Store. This should | ||
| be fatal for the worker. | ||
| """ |
There was a problem hiding this comment.
We need to settle on a standard for
- Adding documentation to the various cython files.
- Breaking them up the behemoth
_raylet.pyxfile into separate files. - Unit testing? I'm not sure if it already exists yet.
edoakes
approved these changes
Jul 16, 2025
alimaazamat
pushed a commit
to alimaazamat/ray
that referenced
this pull request
Jul 24, 2025
…ay-project#53856) - Adding stats about spilling, sealed objects, and bytes used instead of just LRU stats to the output. - Adding documentation to the CoreWorker API in .pyx and .pxd files. - Returning a Status instead of an unhandled exception. Example output ``` Plasma Usage: - objects spillable: 0 - bytes spillable: 0 - objects unsealed: 0 - bytes unsealed: 0 - objects in use: 0 - bytes in use: 0 - objects evictable: 0 - bytes evictable: 0 - objects created by worker: 0 - bytes created by worker: 0 - objects restored: 0 - bytes restored: 0 - objects received: 0 - bytes received: 0 - objects errored: 0 - bytes errored: 0 Eviction Stats: (global lru) capacity: 18323147980 (global lru) used: 0% (global lru) num objects: 0 (global lru) num evictions: 0 (global lru) bytes evicted: 0 ``` --------- Signed-off-by: irabbani <irabbani@anyscale.com> Signed-off-by: alimaazamat <alima.azamat2003@gmail.com>
krishnakalyan3
pushed a commit
to krishnakalyan3/ray
that referenced
this pull request
Jul 30, 2025
…ay-project#53856) - Adding stats about spilling, sealed objects, and bytes used instead of just LRU stats to the output. - Adding documentation to the CoreWorker API in .pyx and .pxd files. - Returning a Status instead of an unhandled exception. Example output ``` Plasma Usage: - objects spillable: 0 - bytes spillable: 0 - objects unsealed: 0 - bytes unsealed: 0 - objects in use: 0 - bytes in use: 0 - objects evictable: 0 - bytes evictable: 0 - objects created by worker: 0 - bytes created by worker: 0 - objects restored: 0 - bytes restored: 0 - objects received: 0 - bytes received: 0 - objects errored: 0 - bytes errored: 0 Eviction Stats: (global lru) capacity: 18323147980 (global lru) used: 0% (global lru) num objects: 0 (global lru) num evictions: 0 (global lru) bytes evicted: 0 ``` --------- Signed-off-by: irabbani <irabbani@anyscale.com> Signed-off-by: Krishna Kalyan <krishnakalyan3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example output