Skip to content

[core] Cleanup naming in core worker scheduling queues #53858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

edoakes
Copy link
Collaborator

@edoakes edoakes commented Jun 16, 2025

Found myself confused in many places reading this code. Cleaning up the naming to be more direct.

  • "accept" and "task handler" -> "execute task"
  • "add" -> "enqueue task"

Will keep chipping away at this.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Jun 16, 2025
edoakes added 3 commits June 16, 2025 14:33
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes changed the title [core] Rename task_handler to execute_task [core] Cleanup naming in core worker scheduling queues Jun 16, 2025
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes marked this pull request as draft June 16, 2025 19:44
Copy link

github-actions bot commented Jul 1, 2025

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jul 1, 2025
@edoakes edoakes closed this Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant