[WIP][core][gpu-objects] GC #53911
Draft
[WIP][core][gpu-objects] GC #53911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,12 +43,12 @@ def __init__(self): | |||
| # | |||
| # Note: Currently, `gpu_object_store` is only supported for Ray Actors. | |||
| self.gpu_object_store: Dict[str, List["torch.Tensor"]] = {} | |||
| # A dictionary that maps from owned object ref to a metadata tuple: (actor handle, object ref). | |||
| # A dictionary that maps from owned object ID to a metadata tuple: (actor handle, object ref). | |||
There was a problem hiding this comment.
Can we key on ObjectID instead of hex str?
There was a problem hiding this comment.
Would you mind sharing why you prefer using an ObjectID rather than a hex string?
python/ray/_raylet.pyx
Outdated
| @@ -2264,6 +2264,14 @@ cdef execute_task_with_cancellation_handler( | |||
| f"Exited because worker reached max_calls={execution_info.max_calls}" | |||
| " for this method.") | |||
|
|
|||
| cdef void clean_up_gpu_object_callback(const CObjectID &c_object_id) nogil: | |||
There was a problem hiding this comment.
Which thread does this callback run on? Can it get blocked by task execution on the main thread?
There was a problem hiding this comment.
TLDR: The callback will be executed on the IO thread.
- The RPC server is running on
io_service_.
ray/src/ray/core_worker/core_worker.cc
Lines 524 to 534 in 1bc0087
io_service_is running on the IO thread.
ray/src/ray/core_worker/core_worker.cc
Line 470 in 1bc0087
|
TODO: check all |
…-tmux7-ray4 Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
|
Investigate:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.