Skip to content

feat: Normalize into immutablejs state #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: Normalize into immutablejs state #3506

wants to merge 1 commit into from

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Jun 12, 2025

Motivation

Solution

Open questions

Copy link

changeset-bot bot commented Jun 12, 2025

⚠️ No Changeset found

Latest commit: c90abbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 12, 2025

Size Change: +6 B (+0.01%)

Total Size: 77.7 kB

ℹ️ View Unchanged
Filename Size Change
examples/test-bundlesize/dist/App.js 3.42 kB 0 B
examples/test-bundlesize/dist/polyfill.js 311 B 0 B
examples/test-bundlesize/dist/rdcClient.js 10.1 kB +6 B (+0.06%)
examples/test-bundlesize/dist/rdcEndpoint.js 5.61 kB 0 B
examples/test-bundlesize/dist/react.js 57.5 kB 0 B
examples/test-bundlesize/dist/webpack-runtime.js 726 B 0 B

compressed-size-action

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: c90abbc Previous: b30806d Ratio
normalizeLong 520 ops/sec (±1.38%) 524 ops/sec (±1.32%) 1.01
denormalizeLong 285 ops/sec (±2.56%) 284 ops/sec (±2.16%) 1.00
denormalizeLong donotcache 1048 ops/sec (±0.80%) 1009 ops/sec (±0.88%) 0.96
denormalizeShort donotcache 500x 1561 ops/sec (±1.04%) 1596 ops/sec (±0.16%) 1.02
denormalizeShort 500x 848 ops/sec (±1.93%) 863 ops/sec (±1.78%) 1.02
denormalizeShort 500x withCache 6512 ops/sec (±0.24%) 6357 ops/sec (±0.76%) 0.98
queryShort 500x withCache 2750 ops/sec (±0.32%) 2762 ops/sec (±0.32%) 1.00
buildQueryKey All 55121 ops/sec (±0.36%) 55270 ops/sec (±0.39%) 1.00
query All withCache 6805 ops/sec (±0.94%) 6788 ops/sec (±0.46%) 1.00
denormalizeLong with mixin Entity 276 ops/sec (±1.89%) 281 ops/sec (±1.78%) 1.02
denormalizeLong withCache 6658 ops/sec (±0.33%) 6522 ops/sec (±0.16%) 0.98
denormalizeLong All withCache 6610 ops/sec (±0.43%) 6416 ops/sec (±0.16%) 0.97
denormalizeLong Query-sorted withCache 6885 ops/sec (±0.20%) 6861 ops/sec (±0.39%) 1.00
denormalizeLongAndShort withEntityCacheOnly 1710 ops/sec (±0.30%) 1702 ops/sec (±0.21%) 1.00
getResponse 5859 ops/sec (±1.54%) 5587 ops/sec (±1.36%) 0.95
getResponse (null) 6899882 ops/sec (±1.63%) 7377465 ops/sec (±0.61%) 1.07
getResponse (clear cache) 283 ops/sec (±2.19%) 276 ops/sec (±2.00%) 0.98
getSmallResponse 3086 ops/sec (±0.71%) 3045 ops/sec (±0.57%) 0.99
getSmallInferredResponse 2340 ops/sec (±0.28%) 2379 ops/sec (±0.43%) 1.02
getResponse Collection 5715 ops/sec (±1.52%) 5646 ops/sec (±1.30%) 0.99
get Collection 5846 ops/sec (±0.34%) 5936 ops/sec (±0.35%) 1.02
get Query-sorted 6838 ops/sec (±0.17%) 6636 ops/sec (±0.34%) 0.97
setLong 533 ops/sec (±0.32%) 526 ops/sec (±0.60%) 0.99
setLongWithMerge 245 ops/sec (±0.14%) 241 ops/sec (±0.39%) 0.98
setLongWithSimpleMerge 262 ops/sec (±0.42%) 262 ops/sec (±0.38%) 1
setSmallResponse 500x 940 ops/sec (±0.35%) 931 ops/sec (±0.46%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@ntucker ntucker force-pushed the norm-imm branch 2 times, most recently from 24e119b to 008fc9c Compare June 27, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant