You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Veykril
changed the title
https://github.com/rust-lang/rust/pull/140748 will require us to adjust our format_args! lowering
rust-lang/rust#140748 will require us to adjust our format_args! lowering
Jun 5, 2025
Thinking about it, why do we even need to mimic rustc with lowering of format_args! exactly? As long as we make sure we have all the formatting traits and expressions it should be fine, after all we don't actually format anything.
We do make use of the formatting output for mir building / eval. We try to render the debug impl for things on hover for example (though its mostly broken due to us failing in various places in std at the moment.
We might? The main immediate problem here is that we just need to fix up the lowering to prevent us from generating diagnostics for our desugared code (as that will cause log spamming again). More of our mir eval is semi broken right now anyways due to lack of support for a bunch of things.
Uh oh!
There was an error while loading. Please reload this page.
rust-lang/rust#140748
It removes the
UnsafeArg
token from the constructor, we need to mimic that and gate on the toolchain versionThe text was updated successfully, but these errors were encountered: