[BUG] Device inconstency in MQF2DistributionLoss raising: RuntimeError: Expected all tensors to be on the same device
#1916
+222
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1916 +/- ##
=======================================
Coverage ? 86.37%
=======================================
Files ? 96
Lines ? 7807
Branches ? 0
=======================================
Hits ? 6743
Misses ? 1064
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fnhirwa
requested review from
benHeid,
fkiraly,
jdb78 and
yarnabrina
as code owners
|
Requesting review from @PranavBhatP - is this loss currently tested via the framework? |
|
No, not in the present state on |
|
I see that this PR handles the soft dependency, so I think it's a good start! Will review this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1182
In the current implementation, the
picnnis initialized during class construction, and the device that it defaults to isn't being updated when the model is moved to another device.to()to ensure thatpicnnis moved along with the loss function.map_x_to_distributionto ensure thatpicnnis on the same device as the input tensor.Also added the tests mocking the accelerators on a high level to test the synchronization of devices within this class.