Skip to content

fix: Error message referring to run blocks in Dynamic expression SPRW-1071 #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

aakashreddy-p
Copy link
Contributor

@aakashreddy-p aakashreddy-p commented May 21, 2025

Description

I have added a condition where, if the user has not run the blocks to preview the dynamic expression (DE), they will receive a proper error message prompting them to run the blocks.

Add Issue Number

Fixes #jira

Add Screenshots/GIFs

image

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • I have linked an issue to the pull request.
  • I have linked a PR type label to the pull request.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.

@aakashreddy-p aakashreddy-p self-assigned this May 21, 2025
@aakashreddy-p aakashreddy-p requested a review from gc-codes as a code owner May 21, 2025 07:42
@aakashreddy-p aakashreddy-p added pr-bugfix This PR fixes a bug enhancement labels May 21, 2025
Comment on lines +160 to 164
{runDynamicExpression
? "No preview available. Please check your expression and try again."
: "Please run the Blocks to check the dynamic expression preview."}
</p>
{/if}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few scenarios are still missing

@itsmdasifraza
Copy link
Member

Math.floor(Math.random() * 10) ++++
I am running this code for the first time and it says to run the previous blocks. that is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement pr-bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants