Add the functionality of response ratio #3370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Astitva877
reviewed
Jun 23, 2025
Astitva877
reviewed
Jun 23, 2025
Astitva877
reviewed
Jun 24, 2025
| @@ -0,0 +1,291 @@ | |||
| <script lang="ts"> | |||
There was a problem hiding this comment.
move this component to common folder.
Astitva877
reviewed
Jun 24, 2025
Comment on lines
40
to
63
| function handleChange(index, event) { | ||
| const isEmpty = event.detail === "" || event.detail === null; | ||
| const activeResponse = activeResponses[index]; | ||
| const responseId = activeResponse.id; | ||
|
|
||
| const oldValue = Number(inputValues.get(responseId) || 0); | ||
|
|
||
| const newNumericValue = isEmpty ? 0 : Number(event.detail); | ||
|
|
||
| const potentialTotal = totalPercentage - oldValue + newNumericValue; | ||
| inputValues.set(responseId, isEmpty ? null : newNumericValue); | ||
|
|
||
| // Recalculate total | ||
| calculateTotal(); | ||
|
|
||
| // Handle error state | ||
| if (potentialTotal <= 100) { | ||
| exceededLimit = false; | ||
| lastModifiedIndex = null; | ||
| } else { | ||
| exceededLimit = true; | ||
| lastModifiedIndex = index; | ||
| } | ||
| } |
Astitva877
reviewed
Jun 24, 2025
Comment on lines
66
to
76
| function calculateTotal() { | ||
| totalPercentage = 0; | ||
|
|
||
| activeResponses.forEach((response) => { | ||
| const value = inputValues.get(response.id); | ||
| totalPercentage += | ||
| value === null || value === undefined || value === "" | ||
| ? 0 | ||
| : Number(value); | ||
| }); | ||
| } |
Astitva877
approved these changes
Jun 24, 2025
Astitva877
merged commit 71f5a04
into
sparrowapp-dev:mock-response-ratio
0 of 4 checks passed
|
🎉 This PR is included in version 2.27.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pr, I have added the functionality of setting the mock response ratio.
Add Issue Number
Fixes #<your_issue_number>
Add Screenshots/GIFs
Add Known Issue
If applicable, add any known issues.
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.