Skip to content

Update README.md #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

Update README.md #1304

merged 3 commits into from
Jun 24, 2025

Conversation

sfc-gh-tteixeira
Copy link
Contributor

📚 Context

Just making sure our dev instructions are correct.

🧠 Description of Changes

Just making sure our dev instructions are correct.

💥 Impact

Size:

  • Small
  • Not small

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation in README.md by simplifying the development environment setup instructions.

  • Removes detailed installation steps for various operating systems
  • Replaces the previous instructions with a simple note to ensure npm is installed
Comments suppressed due to low confidence (1)

README.md:13

  • The simplification greatly reduces detailed setup instructions which might be useful for developers using non-standard setups or different operating systems. Consider adding a note or a link to a more detailed guide if this less detailed instruction is insufficient for some environments.
Make sure you have `npm` installed.

README.md Outdated

$ python -m venv venv
```
Make sure you have `npm` installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Make sure you have `npm` installed.
Make sure you have [`npm`](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm) installed.

Don't we also need people to install make? It comes along with the xcode-select --install command on Mac, I think.

@sfc-gh-dmatthews
Copy link
Contributor

I approved it, but I think we need to put a couple more details back in so the setup instructions are complete.

@sfc-gh-dmatthews sfc-gh-dmatthews merged commit 35a3763 into main Jun 24, 2025
5 checks passed
@sfc-gh-dmatthews sfc-gh-dmatthews deleted the sfc-gh-tteixeira-patch-1 branch June 24, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants