Skip to content

nested VT: Introduce ::view-transition-group-children #52604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 16, 2025

This patch adds a new element within the view transition structure

::view-transition
::view-transition-group()
::view-transition-image-pair(
)
::view-transition-old()
::view-transition-new(
)
::view-transition-group-children() -- this is new
::view-transition-group(
)
::view-transition-image-pair()
::view-transition-old(
)
::view-transition-new(*)
...

The name is per resolution
w3c/csswg-drafts#11926 (comment)

R=nrosenthal@chromium.org, kevers@chromium.org

Bug: 405168694
Change-Id: I1c230532fb7840ac60048fa2ddd504e87eee043c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6520016
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1467051}

This patch adds a new element within the view transition structure

::view-transition
  ::view-transition-group(*)
    ::view-transition-image-pair(*)
      ::view-transition-old(*)
      ::view-transition-new(*)
    ::view-transition-group-children(*) -- this is new
      ::view-transition-group(*)
        ::view-transition-image-pair(*)
          ::view-transition-old(*)
          ::view-transition-new(*)
      ...

The name is per resolution
w3c/csswg-drafts#11926 (comment)

R=nrosenthal@chromium.org, kevers@chromium.org

Bug: 405168694
Change-Id: I1c230532fb7840ac60048fa2ddd504e87eee043c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6520016
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1467051}
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title nested VT: Introduce ::view-transition-nested-groups nested VT: Introduce ::view-transition-group-children May 29, 2025
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-6520016 branch from 3efc075 to 1d0c47e Compare May 29, 2025 17:21
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f38094d into master May 29, 2025
20 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-6520016 branch May 29, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants