ScopedVT: Fix pseudo tree effect node placement. #52732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaintPropertyTreeBuilder had special logic to move the ::view-transition effect node to the top of the effect tree, which isn't appropriate for scoped transitions. The ::view-transition effect is now placed as a sibling of the scope's ViewTransitionEffect. This ensures that the rendered pseudo tree is subject to the effects of the scope's ancestors, such as participating in an outer transition. Bug: 415945850 Change-Id: Icde162db762146cece682aee0678a95767cbaf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6579426 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1464220}
wpt-pr-bot
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaintPropertyTreeBuilder had special logic to move the ::view-transition
effect node to the top of the effect tree, which isn't appropriate for
scoped transitions.
The ::view-transition effect is now placed as a sibling of the scope's
ViewTransitionEffect. This ensures that the rendered pseudo tree is
subject to the effects of the scope's ancestors, such as participating
in an outer transition.
Bug: 415945850
Change-Id: Icde162db762146cece682aee0678a95767cbaf46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6579426
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464220}