Skip to content

Revert "[WebNN] Fuse QDQ for element-wise logical on tflite" #53164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

This reverts commit 9cf94ffffd9359cbcfd757d8258c07bc880863ee.

Reason for revert: Causing consistent failures on Mac builders
i.e. https://ci.chromium.org/ui/p/chromium/builders/ci/mac14-arm64-rel-tests/25648/test-results

Bug: 401281047
Original change's description:

[WebNN] Fuse QDQ for element-wise logical on tflite

This CL supports fusing QDQ for element-wise logical equal, notEqual
greater, greaterOrEqual, lesser and lesserOrEqual on tflite.

The output data type of element-wise logical is uint8, so the next
operation isn't quantizeLinear, but dq -> op can be fused to
quantized operator.

Bug: 401281047
Change-Id: If1935e6cece8282c7d5e48cbe86c5a85a6b6e925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6639273
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Commit-Queue: Wei4 Wang <wei4.wang@intel.com>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Reviewed-by: Junwei Fu <junwei.fu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1474141}

Bug: 401281047
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I302c14afc13bc713e991028d3ea8ef6b722983d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6637959
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Nidhi Jaju <nidhijaju@chromium.org>
Owners-Override: Nidhi Jaju <nidhijaju@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1474154}

This reverts commit 9cf94ffffd9359cbcfd757d8258c07bc880863ee.

Reason for revert: Causing consistent failures on Mac builders
i.e. https://ci.chromium.org/ui/p/chromium/builders/ci/mac14-arm64-rel-tests/25648/test-results

Bug: 401281047
Original change's description:
> [WebNN] Fuse QDQ for element-wise logical on tflite
>
> This CL supports fusing QDQ for element-wise logical equal, notEqual
> greater, greaterOrEqual, lesser and lesserOrEqual on tflite.
>
> The output data type of element-wise logical is uint8, so the next
> operation isn't quantizeLinear, but `dq -> op` can be fused to
> quantized operator.
>
> Bug: 401281047
> Change-Id: If1935e6cece8282c7d5e48cbe86c5a85a6b6e925
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6639273
> Reviewed-by: ningxin hu <ningxin.hu@intel.com>
> Commit-Queue: Wei4 Wang <wei4.wang@intel.com>
> Reviewed-by: Phillis Tang <phillis@chromium.org>
> Reviewed-by: Junwei Fu <junwei.fu@intel.com>
> Cr-Commit-Position: refs/heads/main@{#1474141}

Bug: 401281047
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I302c14afc13bc713e991028d3ea8ef6b722983d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6637959
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Nidhi Jaju <nidhijaju@chromium.org>
Owners-Override: Nidhi Jaju <nidhijaju@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1474154}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 37ab6e6 into master Jun 16, 2025
27 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-2e9929d241 branch June 16, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants