started treating hash objects as HTTP form data. Cleaned up the clientlogin code to use this.

Author: jfisher

lib/gdata/auth/clientlogin.rb

@@ -57,13 +57,15 @@ def initialize(service, options = {})
       # to a previously issued CAPTCHA challenge.
       def get_token(username, password, source, login_token = nil, 
           login_captcha = nil)
-        source = CGI.escape(source)
-        password = CGI.escape(password)
-        username = CGI.escape(username)
-        body = "accountType=#{@account_type}&Email=#{username}" +
-               "&Passwd=#{password}&service=#{@service}&source=#{source}"
+        body = Hash.new
+        body['accountType'] = @account_type
+        body['Email'] = username
+        body['Passwd'] = password
+        body['service'] = @service
+        body['source'] = source
         if login_token and login_captcha
-          body += "&logintoken=#{login_token}&logincaptcha=#{login_captcha}"
+          body['logintoken'] = login_token
+          body['logincaptcha'] = login_captcha
         end
 
         request = GData::HTTP::Request.new(@auth_url, :body => body, 

lib/gdata/http/default_service.rb

@@ -47,7 +47,14 @@ def make_request(request)
           raise ArgumentError, "Unsupported HTTP method specified."
         end
 
-        req.body = request.body
+        case request.body
+        when String
+          req.body = request.body
+        when Hash
+          req.set_form_data(request.body)
+        else
+          req.body = request.body.to_s
+        end
         request.headers.each do |key, value|
           req[key] = value
         end