Skip to content

Localize Details block summary text #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

t-hamano
Copy link
Contributor

Part of #776

Testing Instructions

  • Insert a Details block into one of the templates and enter summary text.
  • Save the template.
  • From the CBT sidebar, click the Save button.
  • Verify that the localization function is applied to the Summary text.

Before

<?php
/**
 * Title: home
 * Slug: twentytwentyfive/home
 * Inserter: no
 */
?>
<!-- wp:details -->
<details class="wp-block-details"><summary>Details Summary</summary><!-- wp:paragraph {"placeholder":"Type / to add a hidden block"} -->
<p><?php esc_html_e('Details Content', 'twentytwentyfive');?></p>
<!-- /wp:paragraph --></details>
<!-- /wp:details -->

After

<?php
/**
 * Title: home
 * Slug: twentytwentyfive/home
 * Inserter: no
 */
?>
<!-- wp:details -->
<details class="wp-block-details"><summary><?php esc_html_e('Details Summary', 'twentytwentyfive');?></summary><!-- wp:paragraph {"placeholder":"Type / to add a hidden block"} -->
<p><?php esc_html_e('Details Content', 'twentytwentyfive');?></p>
<!-- /wp:paragraph --></details>
<!-- /wp:details -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant