-
Notifications
You must be signed in to change notification settings - Fork 3k
Added PHPDoc block for the_content filter hooks in the Twenty Seventeen theme #9132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PHPDoc block for the_content filter hooks in the Twenty Seventeen theme #9132
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Nice! TT1 have similar comment wordpress-develop/src/wp-content/themes/twentytwentyone/inc/template-functions.php Line 400 in c08537d
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
While reviewing the hooks in 2017, I noticed that a docblock was missing for the wordpress-develop/src/wp-content/themes/twentyseventeen/functions.php Lines 709 to 712 in a8b9dc1
While fixing the docblock for the other hook, it would be great to fix this one too. Are you able to assist? The hook was introduced in version 3.7 of the theme. |
@peterwilsoncc The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sabernhardt Thanks Stephen, I appreciate the pointer.
Trac ticket: https://core.trac.wordpress.org/ticket/63637
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.