Skip to content

Add version parsing from Pipfile #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aradkdj
Copy link

@aradkdj aradkdj commented Mar 27, 2025

Description:
Add version parsing from a Pipfile, passed through the python-version-file option.

Related issue:
#574

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@aradkdj aradkdj requested a review from a team as a code owner March 27, 2025 03:04
@aradkdj aradkdj force-pushed the feature/add-version-parsing-from-Pipfile branch from f387444 to 0fc6a29 Compare May 30, 2025 23:11
@mahabaleshwars
Copy link
Contributor

Hi @aradkdj,
The checks are currently failing on your PR. Could you please address the issues and pull the latest updates from the main branch? Once that's done, we can proceed with the review.

Thanks!

@aradkdj aradkdj force-pushed the feature/add-version-parsing-from-Pipfile branch from 0fc6a29 to c44ab2e Compare June 4, 2025 03:16
@mahabaleshwars
Copy link
Contributor

Hi @aradkdj,
The checks are still failing. Please review the previous feedback comment, and let me know if you need any assistance to move forward.

@mahabaleshwars mahabaleshwars self-assigned this Jun 9, 2025
@aradkdj
Copy link
Author

aradkdj commented Jun 10, 2025

Sure. I took a look at it and could not figure out why it's failing on CI but not on the unit tests. Any pointer would be appreciated

@mahabaleshwars
Copy link
Contributor

Hi @aradkdj,
This issue is occurring due to an incorrect file name specified in the .yml file. It should be 'Pipfile' instead of 'Pipenv'. The logic performs a strict check on the file name:

else if (versionFile.match('Pipfile')) {
  return getVersionInputFromPipfileFile(versionFile);
}

Since 'Pipenv' doesn't match 'Pipfile', the corresponding logic isn't triggered. Please update the file name to resolve the issue.

@aradkdj aradkdj force-pushed the feature/add-version-parsing-from-Pipfile branch from c44ab2e to e87e3e9 Compare June 12, 2025 23:20
@aradkdj
Copy link
Author

aradkdj commented Jun 13, 2025

Sorry I missed that. It should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants