Add Architecture-Specific PATH Management for Python with --user Flag on Windows #1122
+156
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the PATH configuration for Windows Python installations when using the --user flag by adding architecture-specific directory handling for Python 3.10+ and adjusting for freethreaded builds.
- Moves a debug log to a new location
- Introduces new logic to append architecture-specific suffixes to the PATH for Windows
- Updates the construction of the user Scripts directory
Comments suppressed due to low confidence (1)
src/find-python.ts:164
- [nitpick] Consider clarifying the conditional handling of the architecture. Using explicit variables or abstractions for base architecture and freethreaded variations can reduce confusion between 'x86' and 'x86-freethreaded' cases.
if (architecture === 'x86' && (major > 3 || (major === 3 && minor >= 10))) {
Comment on lines
+162
to
+176
| // Append '-32' for x86 architecture if Python version is >= 3.10 | ||
| if ( | ||
| architecture === 'x86' && | ||
| (major > 3 || (major === 3 && minor >= 10)) | ||
| ) { | ||
| versionSuffix += '-32'; | ||
| } else if (architecture === 'arm64') { | ||
| versionSuffix += '-arm64'; | ||
| } | ||
| // Append 't' for freethreaded builds | ||
| if (freethreaded) { | ||
| versionSuffix += 't'; | ||
| if (architecture === 'x86-freethreaded') { | ||
| versionSuffix += '-32'; | ||
| } else if (architecture === 'arm64-freethreaded') { |
There was a problem hiding this comment.
[nitpick] Consider refactoring the nested freethreaded logic to clearly separate the base architecture check from freethreaded adjustments. This may help prevent potential misconfigurations when combining freethreaded and architecture-specific suffixes.
Suggested change
| // Append '-32' for x86 architecture if Python version is >= 3.10 | |
| if ( | |
| architecture === 'x86' && | |
| (major > 3 || (major === 3 && minor >= 10)) | |
| ) { | |
| versionSuffix += '-32'; | |
| } else if (architecture === 'arm64') { | |
| versionSuffix += '-arm64'; | |
| } | |
| // Append 't' for freethreaded builds | |
| if (freethreaded) { | |
| versionSuffix += 't'; | |
| if (architecture === 'x86-freethreaded') { | |
| versionSuffix += '-32'; | |
| } else if (architecture === 'arm64-freethreaded') { | |
| // Determine base architecture suffix | |
| if (architecture === 'x86' && (major > 3 || (major === 3 && minor >= 10))) { | |
| versionSuffix += '-32'; | |
| } else if (architecture === 'arm64') { | |
| versionSuffix += '-arm64'; | |
| } | |
| // Adjust for freethreaded builds | |
| if (freethreaded) { | |
| versionSuffix += 't'; | |
| if (architecture.includes('x86')) { | |
| versionSuffix += '-32'; | |
| } else if (architecture.includes('arm64')) { |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This update modifies the PATH handling for Python installations on Windows, specifically for the --user flag. For Python 3.10 and above, architecture-specific directories (e.g., Python310-32) are added to the PATH, while for earlier versions, the default --user path is used. This ensures proper environment configuration for user-installed Python versions based on version and architecture.
Related issue:
#1005