Skip to content

Fix loading of IDE registered JSF libraries #8623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Fix loading of IDE registered JSF libraries #8623

merged 1 commit into from
Jul 7, 2025

Conversation

NicolaIsotta
Copy link
Contributor

@NicolaIsotta NicolaIsotta commented Jun 25, 2025 •
edited by matthiasblaesing
Loading

Just discoreved, opening a legacy ant web project, that the loading of JSF libraries registered in the IDE does not work. This commit fixes it.

@NicolaIsotta
Copy link
Contributor Author

NicolaIsotta commented Jun 25, 2025 •
edited
Loading

To test:
New Project -> Java with Ant -> Java Web -> Web Application -> Next -> Next -> Choose a Tomcat -> Next -> Check "Java Server Faces" and look at the "Registered Libraries" combo

@mbien mbien added Java EE/Jakarta EE [ci] enable enterprise job Ant [ci] enable "build tools" tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jun 26, 2025
@apache apache locked and limited conversation to collaborators Jun 26, 2025
@apache apache unlocked this conversation Jun 26, 2025
@matthiasblaesing matthiasblaesing added this to the NB27 milestone Jul 6, 2025
matthiasblaesing
matthiasblaesing approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. Tested with jakarta and javax based JSF library and both cases are covered.

@matthiasblaesing matthiasblaesing merged commit 8d7d0c4 into apache:master Jul 7, 2025
33 checks passed
@NicolaIsotta NicolaIsotta deleted the jsf-lib-fix branch July 7, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing

Assignees
No one assigned
Labels
Ant [ci] enable "build tools" tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java EE/Jakarta EE [ci] enable enterprise job
Projects
None yet
Milestone
NB27
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolaIsotta @matthiasblaesing @mbien