add wait-for-service-stability-max-delay-seconds input #756
+44
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a new input
wait-for-service-stability-max-delay-secondswhich allows users of the action to configure themaxDelayparameter that's passed towaitUntilServicesStable.Goal here is to be able to configure the action to poll the deployment status more frequently. Our service deploys take between 2-3 minutes in ECS but we frequently see the action taking 5-6 minutes to complete in GHA and we believe it's due to the default
maxDelayof 120 seconds.Have updated the existing test cases to support this new input. Please let me know if you'd like additional test cases added and of course I welcome any other suggestions.
Thanks!
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.