Skip to content

Fixed bugs in the C thread example program and updated some comments for build command. #11155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025

Conversation

yomaytk
Copy link
Contributor

@yomaytk yomaytk commented Jun 29, 2025

This PR fixed the bug in examples/threads.c, and removed the cargo build command for all examples/*.c files in the same manner as #11132.

examples/threads.wat imports the hello function with no arguments, but in threads.c the imported function was defined to take one argument (i32 type). That occurred the error > Error instantiating module!\n, so I fixed the signature and updated it to output the thread ID.

@yomaytk yomaytk requested a review from a team as a code owner June 29, 2025 02:54
@yomaytk yomaytk requested review from pchickey and removed request for a team June 29, 2025 02:54
Copy link
Contributor

@pchickey pchickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pchickey pchickey added this pull request to the merge queue Jun 30, 2025
Merged via the queue into bytecodealliance:main with commit 57ba95e Jun 30, 2025
42 checks passed
@yomaytk yomaytk deleted the fix-examples-c branch July 1, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants