Skip to content

Description with spaces and MethodTitle quotes #1715

Open
@lipchev

Description

@lipchev

I've noticed that having a white space in the Description of a benchmark causes additional quotes to be added to the MethodTitle (all exporters).

Method Mean Error StdErr Min Max Median Ratio MannWhitney(5%) Gen 0 Gen 1 Gen 2 Allocated
'new (value, unit)' 743.6 ns NA 0.0 ns 743.6 ns 743.6 ns 743.6 ns 1.00 Base - - - -
FromUnit(quantityValue) 1,395.2 ns NA 0.0 ns 1,395.2 ns 1,395.2 ns 1,395.2 ns 1.88 ? - - - -
Quantity.From(value,unit) 3,785.3 ns NA 0.0 ns 3,785.3 ns 3,785.3 ns 3,785.3 ns 5.09 ? - - - 32 B
'Quantity<Q,U>.From(value, unit)' 5,232.6 ns NA 0.0 ns 5,232.6 ns 5,232.6 ns 5,232.6 ns 7.04 ? - - - 56 B
'Quantity.From(value, randomUnit)' 8,620.2 ns NA 0.0 ns 8,620.2 ns 8,620.2 ns 8,620.2 ns 11.59 ? - - - 32 B

This was also the case in v0.12 I just really noticed it now when I tried to 'echo' a json string

Activity

added a commit that references this issue on Nov 1, 2022
80f1e11
linked a pull request that will close this issue on Nov 1, 2022
added 2 commits that reference this issue on Nov 1, 2022
a15545b

Fix dotnet#1715 with the ability to revert the old behavior

b703454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @lipchev@YegorStepanov

    Issue actions

      Description with spaces and MethodTitle quotes · Issue #1715 · dotnet/BenchmarkDotNet