Skip to content

cmd/workload: rework tracegen to run tracing at block level #32092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 2, 2025
Merged

cmd/workload: rework tracegen to run tracing at block level #32092

merged 7 commits into from
Jul 2, 2025

Conversation

rjl493456442
Copy link
Member

This PR changes the trace test to block level, aiming for better execution performance.

@rjl493456442 rjl493456442 requested a review from fjl as a code owner June 25, 2025 05:19
zsfelfoldi
zsfelfoldi approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@zsfelfoldi zsfelfoldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some cases file.Close() was called twice, fixed that, otherwise LGTM.

@zsfelfoldi zsfelfoldi merged commit 6eb212b into ethereum:master Jul 2, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsfelfoldi zsfelfoldi

@fjl fjl

Assignees

@zsfelfoldi zsfelfoldi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjl493456442 @zsfelfoldi