Skip to content

Conversation

thettler
Copy link

Issue

The install command searches for a app.js but with a new Laravel install comes a app.ts. This Throws an error and the plugin is not added to the vue mount.

Solution

I updated the install command to check if an .js or .ts app exists. Also i changed the
/return createApp.*?mount\(el\);/s regex to /createApp.*?mount\(el\);/s because in the Inertia docs and the new Laravel Installation the return isn't present and the command would not work with.

Test

I saw that there are no Tests for the Commands, or i didn't found them. I added one Test Class for the AddVuePlugin Console Action but limited my self to only testing the happy path and my new Addition to keep the PR small. The Test it self is a bit hacky but should work. I would be happy if someone has a more elegant Solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant