Fix app.ts throwing error because app.js is not found #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The install command searches for a app.js but with a new Laravel install comes a app.ts. This Throws an error and the plugin is not added to the vue mount.
Solution
I updated the install command to check if an .js or .ts app exists. Also i changed the
/return createApp.*?mount\(el\);/s
regex to/createApp.*?mount\(el\);/s
because in the Inertia docs and the new Laravel Installation thereturn
isn't present and the command would not work with.Test
I saw that there are no Tests for the Commands, or i didn't found them. I added one Test Class for the AddVuePlugin Console Action but limited my self to only testing the happy path and my new Addition to keep the PR small. The Test it self is a bit hacky but should work. I would be happy if someone has a more elegant Solution.