Skip to content

x/pkgsite: hyperlink does not inherit version for standard library packages. #68755

Open
golang/pkgsite
#94
@alexbozhenko

Description

@alexbozhenko
Contributor

What is the URL of the page with the issue?

https://pkg.go.dev/iter@go1.23rc2#hdr-Standard_Library_Usage

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0

Screenshot

Working link to the same package, includes version:
image

Broken link to a different package, does not include version:
image

What did you do?

  1. Open https://pkg.go.dev/iter@go1.23rc2#hdr-Standard_Library_Usage
  2. Click on the link in For example, [maps.Keys](https://pkg.go.dev/maps#Keys) returns an iterator over the keys of a map

What did you see happen?

Observe that the link points to the latest(go1.22.6), which does not contain maps.Keys function. The anchor link is broken.
Note: 1.23rc2 does contain that function.

What did you expect to see?

I expected that if I explicitly chose to browse version 1.23rc2, all links would be pointing to that version.

Activity

added this to the Unreleased milestone on Aug 7, 2024
gabyhelp

gabyhelp commented on Aug 7, 2024

@gabyhelp

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

alexbozhenko

alexbozhenko commented on Aug 7, 2024

@alexbozhenko
ContributorAuthor

@julieqiu, @jba
Hi!
Seems like last time this logic was modified in:
https://go-review.googlesource.com/c/pkgsite/+/241818

If you agree that this should be fixed, I would like to work on the fix.

added
NeedsFixThe path to resolution is known, but the work has not been done.
on Aug 8, 2024
hyangah

hyangah commented on Aug 8, 2024

@hyangah
Contributor

I agree that it is a bug. (@jba please confirm so @alexbozhenko can start to work on it)

jba

jba commented on Aug 8, 2024

@jba
Contributor

Yes it's a bug. I wonder why https://go.dev/cl/241818 didn't fix it?
Thanks for offering to work on it!

gopherbot

gopherbot commented on Aug 16, 2024

@gopherbot
Contributor

Change https://go.dev/cl/606395 mentions this issue: internal/fetch: add versioning for links to std packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

NeedsFixThe path to resolution is known, but the work has not been done.help wantedpkgsite

Type

No type

Projects

No projects

Relationships

None yet

    Development

    Participants

    @hyangah@alexbozhenko@gopherbot@jba@gabyhelp

    Issue actions

      x/pkgsite: hyperlink does not inherit version for standard library packages. · Issue #68755 · golang/go