Skip to content

KEP-5325: HPA - Improve pod selection accuracy across workload types #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 64 commits into from
Jun 18, 2025
Merged

KEP-5325: HPA - Improve pod selection accuracy across workload types #5331

merged 64 commits into from
Jun 18, 2025
+1,187 −0

Conversation

omerap12
Copy link
Member

  • One-line PR description: HPA - Improve pod selection accuracy across workload types

/sig autoscaling

@omerap12
5325-hpa-pod-selection-accuracy
bb3f849 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 22, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 22, 2025
@omerap12
Copy link
Member Author

This is a work in progress - looking for feedback and opinions.

@omerap12 omerap12 changed the title 5325-hpa-pod-selection-accuracy KEP-5325: HPA pod selection accuracy May 22, 2025
adrianmoisey
adrianmoisey suggested changes May 22, 2025
View reviewed changes
Copy link
Member

@adrianmoisey adrianmoisey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some low hanging changes

omerap12 and others added 8 commits May 23, 2025 12:03
@omerap12 @adrianmoisey
update KEP number
fec53e1 
Co-authored-by: Adrian Moisey <adrian@changeover.za.net>
@omerap12 @adrianmoisey
other sigs are participating
40132d9 
Co-authored-by: Adrian Moisey <adrian@changeover.za.net>
@omerap12 @adrianmoisey
update creation date
99c0097 
Co-authored-by: Adrian Moisey <adrian@changeover.za.net>
@omerap12 @adrianmoisey
empty see-also and replaces
ec7e2bc 
Co-authored-by: Adrian Moisey <adrian@changeover.za.net>
@omerap12 @adrianmoisey
alpha stage
930cef1 
Co-authored-by: Adrian Moisey <adrian@changeover.za.net>
@omerap12 @adrianmoisey
update milestone section
c1f1d29 
Co-authored-by: Adrian Moisey <adrian@changeover.za.net>
@omerap12 @adrianmoisey
update status
adebda0 
Co-authored-by: Adrian Moisey <adrian@changeover.za.net>
@omerap12
Add sections
6b9b6c6 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12 omerap12 changed the title KEP-5325: HPA pod selection accuracy KEP-5325: HPA - Improve pod selection accuracy across workload types May 23, 2025
@omerap12
update title
4b582b6 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
soltysh
soltysh reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I focused mostly on the design details, including the API surface. But once this gets opt-ed into the release I'll look carefully for the remaining bits, including the PRR portion of the doc.

keps/sig-autoscaling/5325-hpa-pod-selection-accuracy/README.md Outdated
- a search in the Kubernetes bug triage tool (https://storage.googleapis.com/k8s-triage/index.html)
-->

- [test name](https://github.com/kubernetes/kubernetes/blob/2334b8469e1983c525c0c6382125710093a25883/test/integration/...): [integration master](https://testgrid.k8s.io/sig-release-master-blocking#integration-master?include-filter-by-regex=MyCoolFeature), [triage search](https://storage.googleapis.com/k8s-triage/index.html?test=MyCoolFeature)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to list integration tests you're planning to add.

omerap12 and others added 3 commits May 28, 2025 20:24
@omerap12 @soltysh
Update keps/sig-autoscaling/5325-hpa-pod-selection-accuracy/README.md
b517592 
Co-authored-by: Maciej Szulik <soltysh@gmail.com>
@omerap12 @soltysh
Update keps/sig-autoscaling/5325-hpa-pod-selection-accuracy/README.md
651e9f3 
Co-authored-by: Maciej Szulik <soltysh@gmail.com>
@omerap12 @soltysh
Update keps/sig-autoscaling/5325-hpa-pod-selection-accuracy/README.md
bac2750 
Co-authored-by: Maciej Szulik <soltysh@gmail.com>
@omerap12 omerap12 mentioned this pull request May 29, 2025
Merged
omerap12 added 3 commits May 29, 2025 06:25
@omerap12
add prod-readiness doc
54c5073 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
removed notes
d52b76f 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
Add pod filter system
dfcb564 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
omerap12 added 4 commits June 12, 2025 07:19
@omerap12
Add Troubleshooting
ce16cff 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
Add event to verify using this feature
dec518a 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
fixed spelling
74458ba 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
update rollout or rollback fail
c2698eb 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12 omerap12 requested a review from gjtempleton June 12, 2025 10:25
@soltysh
Copy link
Contributor

soltysh commented Jun 16, 2025

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 16, 2025
soltysh
soltysh reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following items are required for PRR approval:

  1. list of planned unit tests in the appropriate section
  2. beta and ga requirements

The rest is nice to have but w/o the above I can't approve the PRR.

keps/sig-autoscaling/5325-hpa-pod-selection-accuracy/README.md
- [ ] (R) Production readiness review approved
- [ ] "Implementation History" section is up-to-date for milestone
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still holds.

keps/sig-autoscaling/5325-hpa-pod-selection-accuracy/README.md Outdated
https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282
-->

We will add a unit test verifying that HPAs with and without the new `selectionStrategy` field are properly validated, both when the feature gate is enabled or not.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still holds.

keps/sig-autoscaling/5325-hpa-pod-selection-accuracy/README.md Outdated
These goals will help you determine what you need to measure (SLIs) in the next
question.
-->
N/A.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still holds, although not required for alpha. But highly encouraged. Especially that you're re-using existing metrics that have SLOs defined.

keps/sig-autoscaling/5325-hpa-pod-selection-accuracy/README.md
- the first Kubernetes release where an initial version of the KEP was available
- the version of Kubernetes where the KEP graduated to general availability
- when the KEP was retired or superseded
-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still holds.

omerap12 and others added 13 commits June 16, 2025 16:30
@omerap12 @soltysh
Update keps/sig-autoscaling/5325-hpa-pod-selection-accuracy/README.md
ec16f01 
Co-authored-by: Maciej Szulik <soltysh@gmail.com>
@omerap12 @soltysh
Update keps/sig-autoscaling/5325-hpa-pod-selection-accuracy/README.md
c225297 
Co-authored-by: Maciej Szulik <soltysh@gmail.com>
@omerap12
selectionStrategy -> SelectionStrategy
6b2e81c 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
add empty line
9efa9f6 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
add empty line
6349422 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
Add implementation history
facff0e 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
Add metrics and unit tests
9ffab8b 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
updated Graduation Criteria
1b89060 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
Add SLOs
782809c 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
update toc
8e00b20 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
Add e2e tests for label selector strategy
cbc862a 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
fixed typo
4acdec5 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
fixed typo
f0607b5 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@gjtempleton
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
soltysh
soltysh approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
the PRR section

keps/sig-autoscaling/5325-hpa-pod-selection-accuracy/README.md
- [ ] (R) Production readiness review approved
- [ ] "Implementation History" section is up-to-date for milestone
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good enough for now.

@gjtempleton
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, omerap12, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit a9bb7b3 into kubernetes:master Jun 18, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raywainman raywainman

@soltysh soltysh

@jackfrancis jackfrancis

@jeremyrickard jeremyrickard

@gjtempleton gjtempleton

+1 more reviewer

@adrianmoisey adrianmoisey

Reviewers whose approvals may not affect merge requirements
Assignees

@gjtempleton gjtempleton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
6 participants
@omerap12 @k8s-ci-robot @raywainman @adrianmoisey @soltysh @gjtempleton