KEP 127: add a metric, describe an error kubelet will return, and target one more beta #5413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/node
44 tasks
|
cc @wojtek-t |
rata
reviewed
Jun 13, 2025
There was a problem hiding this comment.
@haircommander thanks! Left two simple comments, feel free to ignore the one about the metric :)
| If that is the case, checking the pod events to see if they are failing for user namespaces reasons | ||
| (like the errors shown in this KEP) is advised, in which case it is recommended to rollback or | ||
| disable the feature gate. | ||
| If there are no successfully created user namespaced pods (but are pods that have been attempted to be created), then there may be an issue with user namespaces on that node. |
There was a problem hiding this comment.
What if we just name the metrics? Like the old text, but using the metrics
Suggested change
| If there are no successfully created user namespaced pods (but are pods that have been attempted to be created), then there may be an issue with user namespaces on that node. | |
| If the kubelet metric `started_user_namespaced_pods_errors_total` has a value close to `started_user_namespaced_pods_total` it means most of pods with userns started are failing. If that is the case, checking the pod events to see if they are failing for user namespaces reasons (like the errors shown in this KEP) is advised, in which case it is recommended to rollback or disable the feature gate. |
| - the version of Kubernetes where the KEP graduated to general availability | ||
| - when the KEP was retired or superseded | ||
| --> | ||
| - Kubernetes 1.34: Feature goes GA |
|
+1 to adding those metrics - they are definitely useful and very easy to reason about and sound reasonbly straightforward to add /approve PRR |
Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
userns-beta3
branch
from
8487267 to
9eead1a
Compare
rata
approved these changes
Jun 16, 2025
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mrunalp, rata, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support User Namespaces in pods #127