-
Notifications
You must be signed in to change notification settings - Fork 4.8k
[12.x] Fix anchor links in Collections docs for consistency #10543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.x] Fix anchor links in Collections docs for consistency #10543
Conversation
I know that this may be a big PR, but I made it cautiously and reviewed it three times. |
Unfortunately it would break all existing links on the web to these methods. |
@taylorotwell Should we target the master branch instead? |
This would work for |
@shaedrich I understand you, but should we leave them not in a kebab-case forever? or there is a way to update them? |
Technically, you could probably create a redirect at https://github.com/laravel/bootcamp.laravel.com/blob/main/routes/web.php to preserve backward compatibility, but I'm not sure if Taylor would be willing to add that kind of complexity to that repository |
I think that too, can we update them in all |
I'm afraid, I can't follow 🤔 |
I mean updating all branches with these changes. |
But the problem will remain as other sites will link here with the current version shortcut. And they won't all update their links |
Maybe, but I've seen many articles that share tips or list top ten helpful methods in Laravel without referencing the official documentation. They rely solely on their own explanations, so I don't think it's a very important issue to worry about. |
That may be true. I just wanted to voice my concerns and my interpretation of Taylor's words earlier. But I don't really know the impact, it would potentially have. |
Description
This PR updates several anchor links in the
collections.md
to use kebab-case to align with the consistent format used throughout the docs. For example:These changes improve overall consistency in the docs, as some method anchors such as
first-or-fail
,first-where
, andreduce-spread
already follow kebab-case formatting.