[llvm-zorg] Set up libc++ premerge testing runner sets. #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This probably needs a lot of work.
|
There's probably a lot I've done wrong -- I'm considering this a learning exercise... |
Updates the way to get the image version out of the other yaml file.
- Create new var, libcxx_machine_type (currently identical to linux_machine_type) and use it where appropriate. - Remove new kubernetes secrets "libcxx_github_pat", "libcxx_release_github_pat", and "libcxx_next_github_pat"; replace uses of them with "linux_github_pat".
- Change machines for libcxx from n2d-standard-64 to n2d-standard-32 - Change 'premerge-platform' to 'premerge-platform-libcxx', change 'linux' to 'linux-libcxx' (update machine taints?) - Remove extra libcxx runner yaml files and the extra libcxx images file; use variables and define libcxx images in the variables file.
|
I have tried to update this as requested; please take another look. |
- Increase max node count for libcxx clusters to 32. - Update the CPU & Memor for libcxx_runners request & limits to suggested values: requests: cpu:55, memory: 200Gi; limits: cpu:32, memory: 128Gi - Create kubernetes_secrets for the 3 libcxx runners and add them to the appropriate namespaces.
boomanaiden154
approved these changes
Jun 24, 2025
|
|
||
| variable "libcxx_next_runner_image" { | ||
| type = string | ||
| default = "" |
There was a problem hiding this comment.
This should probably be filled out with something, even if it's just copied from libcxx_runner_image for now.
Current value (was "") is now same as value for libcxx_runner_image.
I have put the output from 'terraform plan' in https://gist.github.com/cmtice/ef54aa9100e4fa144379fb4c137c26a5 Let me know if you can't see it. |
cmtice
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new runner sets for libc++ premerge testing in the LLVM Github premerge testing infrastructure.