Skip to content

[llvm-zorg] Set up libc++ premerge testing runner sets. #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 25, 2025
Merged

Conversation

cmtice
Copy link
Contributor

@cmtice cmtice commented Jun 17, 2025

Create new runner sets for libc++ premerge testing in the LLVM Github premerge testing infrastructure.

@cmtice
Copy link
Contributor Author

cmtice commented Jun 17, 2025

There's probably a lot I've done wrong -- I'm considering this a learning exercise...

Updates the way to get the image version out of the other yaml file.
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments.

cmtice added 2 commits June 20, 2025 09:53
- Create new var, libcxx_machine_type (currently identical to
  linux_machine_type) and use it where appropriate.
- Remove new kubernetes	secrets	"libcxx_github_pat",
  "libcxx_release_github_pat", and "libcxx_next_github_pat"; replace uses of
  them with "linux_github_pat".
- Change machines for libcxx from n2d-standard-64 to n2d-standard-32
- Change 'premerge-platform' to 'premerge-platform-libcxx', change
  'linux' to 'linux-libcxx' (update machine taints?)
- Remove extra libcxx runner yaml files and the extra libcxx images
  file; use variables and define libcxx images in the variables file.
@cmtice
Copy link
Contributor Author

cmtice commented Jun 24, 2025

I have tried to update this as requested; please take another look.

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost looks good.

- Increase max node count for libcxx clusters to 32.
- Update the CPU & Memor for libcxx_runners request & limits to	suggested
  values: requests: cpu:55, memory: 200Gi; limits: cpu:32, memory: 128Gi
- Create kubernetes_secrets for	the 3 libcxx runners and add them to the
  appropriate namespaces.
@cmtice cmtice marked this pull request as ready for review June 24, 2025 15:36
@cmtice cmtice requested a review from lnihlen June 24, 2025 15:36
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put the output of running terraform plan into a Github Gist/paste somewhere so we can see that there's nothing weird going on before you run terraform apply?


variable "libcxx_next_runner_image" {
type = string
default = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be filled out with something, even if it's just copied from libcxx_runner_image for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Current value (was "") is now  same as value for libcxx_runner_image.
@cmtice
Copy link
Contributor Author

cmtice commented Jun 24, 2025

Could you put the output of running terraform plan into a Github Gist/paste somewhere so we can see that there's nothing weird going on before you run terraform apply?

I have put the output from 'terraform plan' in https://gist.github.com/cmtice/ef54aa9100e4fa144379fb4c137c26a5

Let me know if you can't see it.

@cmtice cmtice changed the title [llvm-zorg] First attempt to set up libc++ runner sets. [llvm-zorg] Set up libc++ premerge testing runner sets. Jun 25, 2025
@cmtice cmtice merged commit e95f358 into main Jun 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants