-
Notifications
You must be signed in to change notification settings - Fork 110
[llvm-zorg] Set up libc++ premerge testing runner sets. #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This probably needs a lot of work.
There's probably a lot I've done wrong -- I'm considering this a learning exercise... |
Updates the way to get the image version out of the other yaml file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments.
- Create new var, libcxx_machine_type (currently identical to linux_machine_type) and use it where appropriate. - Remove new kubernetes secrets "libcxx_github_pat", "libcxx_release_github_pat", and "libcxx_next_github_pat"; replace uses of them with "linux_github_pat".
- Change machines for libcxx from n2d-standard-64 to n2d-standard-32 - Change 'premerge-platform' to 'premerge-platform-libcxx', change 'linux' to 'linux-libcxx' (update machine taints?) - Remove extra libcxx runner yaml files and the extra libcxx images file; use variables and define libcxx images in the variables file.
I have tried to update this as requested; please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost looks good.
- Increase max node count for libcxx clusters to 32. - Update the CPU & Memor for libcxx_runners request & limits to suggested values: requests: cpu:55, memory: 200Gi; limits: cpu:32, memory: 128Gi - Create kubernetes_secrets for the 3 libcxx runners and add them to the appropriate namespaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you put the output of running terraform plan
into a Github Gist/paste somewhere so we can see that there's nothing weird going on before you run terraform apply
?
|
||
variable "libcxx_next_runner_image" { | ||
type = string | ||
default = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be filled out with something, even if it's just copied from libcxx_runner_image
for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Current value (was "") is now same as value for libcxx_runner_image.
I have put the output from 'terraform plan' in https://gist.github.com/cmtice/ef54aa9100e4fa144379fb4c137c26a5 Let me know if you can't see it. |
Create new runner sets for libc++ premerge testing in the LLVM Github premerge testing infrastructure.