Skip to content

Salesrule Subselect with Quantity condition Fail to apply #39965

@senthilengg

Description

@senthilengg

Preconditions and environment

  • Version 2.4.8 and below

Steps to reproduce

  1. Create a cart price rule with Qty >= 1 and any discount % . Ensure its a no coupon. Refer Screenshot below
    Image
  2. Add a product to cart

Expected result

Discount should apply

Actual result

Discount didn't apply

Additional information

Because of the below line of code which should return true if no conditions, similar to found and other classes

https://github.com/magento/magento2/blob/2.4.8/app/code/Magento/SalesRule/Model/Rule/Condition/Product/Subselect.php#L160

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
    Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
    Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
    Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
    Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Activity

m2-assistant

m2-assistant commented on Jun 6, 2025

@m2-assistant

Hi @senthilengg. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

self-assigned this
on Jun 6, 2025
m2-assistant

m2-assistant commented on Jun 6, 2025

@m2-assistant

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    5. Add label Issue: Confirmed once verification is complete.
    6. Make sure that automatic system confirms that report has been added to the backlog.
engcom-Bravo

engcom-Bravo commented on Jun 6, 2025

@engcom-Bravo
Contributor

Hi @senthilengg,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are able to reproduce the issue.Kindly refer the screenshots.

Image

Image Image

Discount is not applying.Hence Confirming the issue.

Thanks.

added
Issue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmed
Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch
Priority: P2A defect with this priority could have functionality issues which are not to expectations.
on Jun 6, 2025
github-jira-sync-bot

github-jira-sync-bot commented on Jun 6, 2025

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/AC-14884 is successfully created for this GitHub issue.

m2-assistant

m2-assistant commented on Jun 6, 2025

@m2-assistant

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

linked a pull request that will close this issue on Jun 6, 2025
senthilengg

senthilengg commented on Jun 7, 2025

@senthilengg
Author

@engcom-Bravo I’ve submitted a PR and it’s a minor one. Except the functional test the rest were passed. Functional failed because of other modules. Do you know when this will be merged, I also have other 2 PR’s as well stuck for the same reason it seems. Appreciate your help. Thanks.

senthilengg

senthilengg commented on Jun 7, 2025

@senthilengg
Author

@magento I am working on this

m2-assistant

m2-assistant commented on Jun 7, 2025

@m2-assistant

Hi @senthilengg! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

engcom-Bravo

engcom-Bravo commented on Jul 15, 2025

@engcom-Bravo
Contributor

Hi @senthilengg,

Adobe Commerce Engineering team started working on this issue. We will reach out to you if we need more information and you will get notified once the issue is fixed. Please leave comments for any further questions.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: Cart & CheckoutComponent: CatalogIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: PR CreatedIndicates that Pull Request has been created to fix issueReported on 2.4.8Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

    Type

    No type

    Projects

    Status

    Ready for Development

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @senthilengg@engcom-Bravo@github-jira-sync-bot

      Issue actions

        Salesrule Subselect with Quantity condition Fail to apply · Issue #39965 · magento/magento2