Test Infra: Always fail afterEach if expected errors don't match logged errors, even if the test isn't otherwise passing.

packages/test/test-end-to-end-tests/src/test/stashedOps.spec.ts

@@ -48,6 +48,7 @@ import type {
 	SharedString,
 } from "@fluidframework/sequence/internal";
 import { SharedObject } from "@fluidframework/shared-object-base/internal";
+import { GenericError } from "@fluidframework/telemetry-utils/internal";
 import {
 	ChannelFactoryRegistry,
 	createSummarizer,
@@ -344,6 +345,12 @@ describeCompat("stashed ops", "NoCompat", (getTestObjectProvider, apis) => {
 		string1.insertText(0, "hello");
 	});
 
+	//* TEMP - DO NOT MERGE
+	it("testing double failure reporting", () => {
+		container1.close(new GenericError("Cause an error to be logged (will fail the 'afterEach' block)"));
+		assert.fail("Cause the test itself to fail");
+	});
+
 	it("resends op", async function () {
 		const pendingOps = await getPendingOps(
 			testContainerConfig,

packages/test/test-version-utils/src/describeCompat.ts

@@ -116,16 +116,12 @@ function createCompatSuite(
 					return provider;
 				}, apis);
 
+				// eslint-disable-next-line prefer-arrow-callback
 				afterEach(function (done: Mocha.Done) {
 					const logErrors = getUnexpectedLogErrorException(provider.tracker);
-					// if the test failed for another reason
-					// then we don't need to check errors
-					// and fail the after each as well
-					if (this.currentTest?.state === "passed") {
-						done(logErrors);
-					} else {
-						done();
-					}
+					// Note: This will add a failure in "afterEach" to the results, which may appear redundant if the test itself failed
+					// However, this extra information may be useful to diagnose the root cause of the failure.
+					done(logErrors);
 					if (resetAfterEach) {
 						provider.reset();
 					}