Skip to content

feat(build-cli): New command check:dependencyRanges #22856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

tylerbutler
Copy link
Member

Adds a new command, check:dependencyRanges, which can be used to verify that no packages have dependencies on Fluid internal versions with ^ or ~, which are unsupported.

This command can replace the find/grep commands in the "Check for caret dependencies on dev versions" CI step.

@github-actions github-actions bot added area: build Build related issues base: main PRs targeted against main branch labels Oct 21, 2024
@tylerbutler tylerbutler marked this pull request as ready for review November 23, 2024 01:36
@tylerbutler
Copy link
Member Author

@scottn12 I'm not sure this is worthwhile unless we ever plan on using the internal version scheme again. @alexvy86 Also curious your thoughts.

@alexvy86
Copy link
Contributor

I like the idea of getting rid of the bash scripts in CI, but it seems like as is, this change would be able to replace the one in "Check for caret dependencies on internal versions" but not the one in "Check for caret dependencies on dev versions". I'd say if we want to merge it, we should make it handle both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants