[LTS] Remove server #23674
[LTS] Remove server #23674
Conversation
|
before committing, I want to revert the change disabling coverage. However, we need to adjust the PAT used for danger GH account first as it's currently over 365 days. I'll also track getting that to a better state (convert to GH app or adopt some other means of bundle size setup, authentication-wise) |
|
There are some remaining references in the form of docs links to things in the server folder (mostly the tinylicious implementation in example packages). I didn't want to bother changing that in this PR as it's plausible those get deleted too. But highly encourage reviewer to look not only for things this PR does but also things I may have missed, as is typical with this sort of change. |
| @@ -378,7 +378,8 @@ stages: | |||
| and( | |||
| succeeded(), | |||
| eq(variables['Build.Reason'], 'PullRequest'), | |||
| ne(variables['System.PullRequest.IsFork'], 'true') | |||
| ne(variables['System.PullRequest.IsFork'], 'true'), | |||
| false | |||
There was a problem hiding this comment.
One of your comments talks about "disabling coverage" which I thought was test coverage but I guess you meant this, right?
Description
Removes the server from LTS. We have no plans or reason to release server from LTS, and keeping it around increases maintenance burden and makes a potential transition to pnpm (from lerna) more complex.