Enable no unchecked record access for more client packages #24130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The purpose of this PR is to enable no-unchecked-record-access for additional client packages by removing the rule configuration from each package’s ESLint config file.
- Removed "@fluid-internal/fluid/no-unchecked-record-access": "warn" entries from various .eslintrc.cjs files.
- In one package (packages/runtime/runtime-utils), the entire rules block was removed as it only contained the rule to be removed.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/test/test-drivers/.eslintrc.cjs | Removed the no-unchecked-record-access rule |
| packages/runtime/runtime-utils/.eslintrc.cjs | Removed the entire rules block containing the rule |
| experimental/dds/sequence-deprecated/.eslintrc.cjs | Removed the no-unchecked-record-access rule |
| packages/test/test-end-to-end-tests/.eslintrc.cjs | Removed the no-unchecked-record-access rule |
| packages/dds/map/.eslintrc.cjs | Removed the no-unchecked-record-access rule |
| packages/test/local-server-tests/.eslintrc.cjs | Removed the no-unchecked-record-access rule |
| packages/dds/tree/.eslintrc.cjs | Removed the no-unchecked-record-access rule |
|
This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling no-unchecked-record-access for 4 packages by removing
no-unchecked-record-accessline in eslint config file per package