Skip to content

Track and expose op/sequenceNumber properties off ContainerRuntime #24195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kian-thompson
Copy link
Contributor

@kian-thompson kian-thompson commented Mar 29, 2025

TODO

AB#28359

@github-actions github-actions bot added area: runtime Runtime related issues base: main PRs targeted against main branch labels Mar 29, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesssss inbox. Is this going to replace RemoteMessageProcessor? That's what I've thought of as the inbox so far.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see it's a bunch of stuff. Cool.

@@ -1951,6 +1969,26 @@ export class ContainerRuntime
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

this._actualMinimumSequenceNumber = params.initialSequenceNumbers.minimumSequenceNumber;
this._lastProcessedSequenceNumber =
params.initialSequenceNumbers.lastProcessedSequenceNumber;
this._lastKnownSeqNumber = params.initialSequenceNumbers.lastProcessedSequenceNumber;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about checkpointSequenceNumber or whatever we get on connect to Ordering Service?

Copy link
Contributor

This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues base: main PRs targeted against main branch status: stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants