Make add value optional and stop writing it in consensusOrderedCollection

[scarlettjlee]

Stop sending value in add op since it has long been replaced by deserializedValue which is needed for GC. AB#7149

Question for reviewers: are additional tests needed? Looks like there is already coverage in handle tests for ConsensusQueue.

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

packages/dds/ordered-collection/src/consensusOrderedCollection.ts:144

• Consider reusing the already computed 'valueSer' instead of calling serializeValue() again in the not-attached branch to avoid redundant computation.

const addValue = this.deserializeValue(

packages/dds/ordered-collection/src/consensusOrderedCollection.ts:153

• Verify that the removal of the 'value' field from the submitted operation aligns with all consumers' expectations and does not break any legacy code segments.

deserializedValue: value,

[jzaffiro]

Changes seem fine to me - in terms of tests, are there any implementations of ConsensusOrderedCollection other than ConsensusQueue? The handleValidation suite only tests storing handles in ConsensusQueue, but if that's the only implementation then I think those tests should be sufficient.

[scarlettjlee]

Changes seem fine to me - in terms of tests, are there any implementations of ConsensusOrderedCollection other than ConsensusQueue? The handleValidation suite only tests storing handles in ConsensusQueue, but if that's the only implementation then I think those tests should be sufficient.

I don't think so. I checked around, although I might have missed a partner usage.