Reduce direct references to SharedTree class and its factory class #24312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
| @@ -2230,6 +2240,7 @@ describe("SharedTree", () => { | |||
| const schema = sf.object("myObject", {}); | |||
| const config = new TreeViewConfiguration({ schema, enableSchemaValidation }); | |||
| const view = tree.viewWith(config); | |||
| assert(view instanceof SchematizingSimpleTreeView); | |||
There was a problem hiding this comment.
The identifier 'SchematizingSimpleTreeView' is used without being imported, which may lead to a compilation error. Please import 'SchematizingSimpleTreeView' from its appropriate module or remove the assertion if it is not needed.
Copilot uses AI. Check for mistakes.
daesunp
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tweak SharedTree tests to make less direct use of the SharedTreeClass and instead prefer its interfaces.
Also reduce unnecessary use of its factory.
These changes make the test suite more compatible with changes like #23729 which adjust how the kernel is used to implement the SharedObject.
Reviewer Guidance
The review process is outlined on this wiki page.