Update version of server used by client #24330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds: propertydds
area: driver
There was a problem hiding this comment.
Copilot reviewed 10 out of 29 changed files in this pull request and generated no comments.
Files not reviewed (19)
- azure/packages/azure-local-service/package.json: Language not supported
- examples/apps/ai-collab/package.json: Language not supported
- examples/apps/blobs/package.json: Language not supported
- examples/apps/presence-tracker/package.json: Language not supported
- examples/apps/staging/package.json: Language not supported
- examples/benchmarks/tablebench/package.json: Language not supported
- examples/client-logger/app-insights-logger/package.json: Language not supported
- examples/external-data/package.json: Language not supported
- examples/service-clients/azure-client/external-controller/package.json: Language not supported
- examples/utils/example-utils/package.json: Language not supported
- examples/utils/migration-tools/package.json: Language not supported
- examples/utils/webpack-fluid-loader/package.json: Language not supported
- examples/version-migration/separate-container/package.json: Language not supported
- examples/version-migration/tree-shim/package.json: Language not supported
- examples/view-integration/external-views/package.json: Language not supported
- experimental/PropertyDDS/packages/property-dds/package.json: Language not supported
- packages/drivers/local-driver/package.json: Language not supported
- packages/drivers/routerlicious-driver/package.json: Language not supported
- packages/framework/client-logger/fluid-telemetry/package.json: Language not supported
Comments suppressed due to low confidence (1)
examples/utils/bundle-size-tests/webpack.config.cjs:122
- The removal of the specific exclusion logic for 'uuid' now causes the function to always return false, which might allow duplicate packages in scenarios where they could be problematic. Please double-check that this configuration change aligns with the intended bundle size management strategy.
exclude: (instance) => false,
CraigMacomber
commented
Apr 11, 2025
| exclude: (instance) => | ||
| // @fluidframework/server-services-client pulls in uuid 9.0.1, and thus bundles using it get this package duplicated until the version of server used in client gets updated. | ||
| // This should not impact size sensitive application as they typically don't include a copy of the server. | ||
| instance.name === "uuid", |
There was a problem hiding this comment.
This is the one non version change: this removal was enabled by the update.
|
This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update version of server used by client.
This realigns the version of
uuidused by the server and client code, avoiding the package duplication.Reviewer Guidance
The review process is outlined on this wiki page.