Remove direct use of TreeFactory and SharedTree class #24377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
There was a problem hiding this comment.
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
packages/dds/tree/src/treeFactory.ts:174
- [nitpick] Consider verifying the intended accessibility of TreeFactory. If it's not meant to be used externally, ensure its visibility is appropriately restricted.
class TreeFactory implements IChannelFactory<ISharedTree> {
packages/dds/tree/src/test/utils.ts:260
- Double-check that changing the factory type from ISharedTree to ITree does not affect tests that expect features specific to ISharedTree.
factory: IChannelFactory<ITree> = DefaultTestSharedTreeKind.getFactory(),
packages/dds/tree/src/test/snapshots/snapshotTestScenarios.ts:253
- Verify that the new factory instantiation pattern via configuredSharedTree creates trees with the expected initial state for snapshot testing scenarios.
const provider = new TestTreeProviderLite(1, configuredSharedTree(options).getFactory(), true);
CraigMacomber
commented
Apr 15, 2025
| /** | ||
| * Shared object wrapping {@link SharedTreeKernel}. | ||
| */ | ||
| class SharedTreeImpl extends SharedObject implements ISharedTree { |
There was a problem hiding this comment.
Moved unchanged, except for new name (to not collide with SharedTree export in this file) and no longer file exported.
jenn-le
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SharedTree class only exists to wrap SharedTreeKernel up in a ISharedObject for use with Fluid's factories and runtimes.
Thus stop using the class and factory directly so that how this adaption of the kernel into a SharedObjectKind is done is no longer implicitly depended on my tests.
This enables the refactor in show this is done from #23729 to not be nearly as disruptive.
Reviewer Guidance
The review process is outlined on this wiki page.