fix(fluid-static):Added userData in member connection details #24485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sure! Here's a clearer and more polished rephrasing: Added `userData` to each user's `connections` to preserve client-specific details. Previously, only `id` and `mode` were stored, which led to data loss when multiple clients shared the same `userId` but had different associated data.
github-actions
bot
added
area: framework
neerajcharokar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We discovered a minor bug that in the Audience service
getMembers, user data withinconnectionsassociated with sameuserIDwas being lost when a user with the sameuserIdjoined the session multiple times i.e. having multiple connections with differentclientId.This was because only
clientIdandmodewere being stored in each connection.This PR addresses the issue by adding a
userDatafield alongsideclientIdandmodein each connection entry, ensuring that user-specific data is accurately preserved for every individual connection.