Skip to content

Bad API report change #24504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CraigMacomber
Copy link
Contributor

Description

This should fail on CI

Reviewer Guidance

Test PR, no review desired.

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree public api change Changes to a public API base: main PRs targeted against main branch labels May 1, 2025
Copy link
Contributor

github-actions bot commented May 1, 2025

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

http://localhost:3000/docs/start/tree-start
- (20:88) 'containe..' => http://localhost:3000/docs/api/container-runtime/icontainerruntimeoptions-interface (HTTP 404)


Stats:
  195689 links
    1566 destination URLs
    1797 URLs ignored
       0 warnings
       1 errors

 ELIFECYCLE  Command failed with exit code 1.

@alexvy86
Copy link
Contributor

alexvy86 commented May 9, 2025

Kicked off a new pipeline run with "Enable system diagnostics" to see if the additional logs tell us anything interesting. Original run is here.

@alexvy86
Copy link
Contributor

It was a regression in api-extractor 7.52.5, fixed in 7.52.8. Should be fixed in our repo by #24599.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants