-
Notifications
You must be signed in to change notification settings - Fork 547
Add a TreeAlpha.key2 method #24623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a TreeAlpha.key2 method #24623
Conversation
// the stored key from the flex-domain, and get property key its simple-domain counterpart was created with. | ||
const storedKey = getStoredKey(node); | ||
const parentSchema = treeNodeApi.schema(parent); | ||
const propertyKey = getPropertyKeyFromStoredKey(parentSchema, storedKey); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
const propertyKey = getPropertyKeyFromStoredKey(parentSchema, storedKey); | |
return getPropertyKeyFromStoredKey(parentSchema, storedKey); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated with suggested change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple nitpicks, but otherwise looks good!
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
Description
This PR adds a
TreeAlpha.key2
method which is meant to eventually replace our publicTree.key
method. This new method now returnsundefined
in the case where there is a root node.