Skip to content

Add a TreeAlpha.key2 method #24623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 16, 2025
Merged

Add a TreeAlpha.key2 method #24623

merged 6 commits into from
May 16, 2025

Conversation

daesunp
Copy link
Contributor

@daesunp daesunp commented May 14, 2025

Description

This PR adds a TreeAlpha.key2 method which is meant to eventually replace our public Tree.key method. This new method now returns undefined in the case where there is a root node.

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree base: main PRs targeted against main branch labels May 14, 2025
// the stored key from the flex-domain, and get property key its simple-domain counterpart was created with.
const storedKey = getStoredKey(node);
const parentSchema = treeNodeApi.schema(parent);
const propertyKey = getPropertyKeyFromStoredKey(parentSchema, storedKey);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
const propertyKey = getPropertyKeyFromStoredKey(parentSchema, storedKey);
return getPropertyKeyFromStoredKey(parentSchema, storedKey);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated with suggested change

@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct changeset-present public api change Changes to a public API labels May 15, 2025
@daesunp daesunp marked this pull request as ready for review May 15, 2025 16:45
@daesunp daesunp requested review from a team as code owners May 15, 2025 16:45
Copy link
Contributor

@Josmithr Josmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple nitpicks, but otherwise looks good!

Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  210260 links
    1663 destination URLs
    1895 URLs ignored
       0 warnings
       0 errors


@daesunp daesunp merged commit 0ddd6b0 into microsoft:main May 16, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants