improvement(test-version-utils): Share TestObjectProvider creation hooks #24662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 16, 2025 15:11
github-actions
bot
added
area: tests
There was a problem hiding this comment.
Pull Request Overview
This PR refactors test setup code to share TestObjectProvider lifecycle hooks across different test suites, unifying the creation, reset, and cleanup logic.
- Replaces duplicated provider creation and teardown logic in describeWithVersions.ts and describeE2eDocs.ts with a shared lifecycle hook factory.
- Refactors describeCompat.ts to use createTestObjectProviderLifecycleHooks and streamlines the provider access pattern.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/test/test-version-utils/src/describeWithVersions.ts | Removes inlined provider state management and cleanup hooks in favor of the shared lifecycle hook. |
| packages/test/test-version-utils/src/describeE2eDocs.ts | Similar refactoring to use lifecycle hooks, removing redundant cleanup and error verification in afterEach hooks. |
| packages/test/test-version-utils/src/describeCompat.ts | Refactors provider creation and cleanup by introducing a currentProvider state and consolidating setup/teardown logic via the new lifecycle hook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #24647 which gives us the same benefits for tests that use the
describeE2eDocshelper by sharing code betweendescribeCompat,describeWithVersions, anddescribeE2eDocs.