-
Notifications
You must be signed in to change notification settings - Fork 549
Add ESLint v9 compatibility to eslint-config-fluid #24687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: alexvy86 <716334+alexvy86@users.noreply.github.com>
Co-authored-by: alexvy86 <716334+alexvy86@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new configs don't seem quite right, they still look like v8 configs. You can look at https://eslint.org/docs/latest/use/configure/migration-guide for a migration guide, including a command that can be run to mostly migrate a config to the new format: npx @eslint/migrate-config <file-path>
Co-authored-by: alexvy86 <716334+alexvy86@users.noreply.github.com>
I've updated all the ESLint v9 configuration files to use the new flat config format. The configs now use ESM syntax with Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
It's hard for me to tell just by looking if the new configs are correct. Can you update that package so it has an npm script that lints it with eslint 9, using the new configuration files, and validate that it runs successfully? That should help us make sure there are no syntax or structure issues in the new configs and that eslint 9 can use them. |
Co-authored-by: alexvy86 <716334+alexvy86@users.noreply.github.com>
I've added a test script ( |
This PR adds support for ESLint v9 to the
@fluidframework/eslint-config-fluid
package while maintaining backward compatibility with ESLint v8.Changes
v9/
) for ESLint v9 compatible configurationspackage.json
with:Usage
To use the ESLint v9 compatible configurations, import them with the
/v9
path segment:For ESLint v9's new configuration format:
Existing ESLint v8 configurations remain available at their current paths for backward compatibility.
Fixes #24686.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.fwupd.org
/usr/bin/fwupdmgr refresh
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.