Revert "feat(datastore): Add experimental isDirty getter to DataStoreRuntime"

[yann-achard-MS]

Reverts #24704

While not yet confirmed, it seems plausible that this change has caused the bohemia FF integration pipeline to fail.

The failing tests in the integration pipeline seem encounter an issue with MockFluidDataStoreContext.containerRuntime.on not being a function. The reverted PR made some changes to MockFluidDataStoreContext.containerRuntime. It's not clear why the changes would cause that failure, but as Mark says, when in doubt, back it out.

See Teams thread for context and discussion.

[Copilot]

Pull Request Overview

This PR reverts the experimental changes related to the isDirty getter in DataStoreRuntime. The changes remove the isDirty getter and associated tests as well as adjustments using the experimental API from stress tests, runtime, and API definitions.

• Removed usage and tests of the experimental isDirty getter in DataStoreRuntime and associated modules.
• Updated local stress test harness and data-store operations to use only the stable consistency validation methods.
• Cleared experimental API references from both runtime and API definition files.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/test/local-server-stress-tests/src/test/localServerStress.spec.ts	Removed experimental validation (isDirty) in favor of stable consistency functions.
packages/test/local-server-stress-tests/src/stressDataObject.ts	Deleted the experimental isDirty getter and removed deprecated import.
packages/test/local-server-stress-tests/src/localServerStressHarness.ts	Adjusted parameter naming in consistency functions to reflect channels rather than clients.
packages/test/local-server-stress-tests/src/ddsOperations.ts	Refactored the object mapping for building the channel map.
packages/test/local-server-stress-tests/src/dataStoreOperations.ts	Entire file removed as part of the revert.
packages/runtime/test-runtime-utils/src/mocksDataStoreContext.ts	Changed mock property initializations from {} to undefined.
packages/runtime/datastore/src/test/dataStoreRuntime.spec.ts	Removed tests for isDirty tracking.
packages/runtime/datastore/src/dataStoreRuntime.ts	Removed pending op count manipulations and experimental isDirty related code.
packages/runtime/datastore-definitions/src/dataStoreRuntime.ts	Removed isDirty property from the experimental API interface.
packages/runtime/datastore-definitions/api-report/datastore-definitions.legacy.alpha.api.md	Removed isDirty reference from the API report.

Comments suppressed due to low confidence (1)

packages/runtime/test-runtime-utils/src/mocksDataStoreContext.ts:54

• The change from an empty object ({}) to undefined for mock properties may lead to unexpected errors if these properties are accessed in tests. Verify that all dependent tests are updated to handle the undefined initialization or provide appropriate defaults.

public containerRuntime: IContainerRuntimeBase = undefined as any;

[github-actions]

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  222975 links
    1707 destination URLs
    1939 URLs ignored
       0 warnings
       0 errors

[markfields]

@yann-achard-MS full support for this back out, but I believe this mocks change ended up being unnecessary for the original PR. So we should be able to just revert that file. That will certainly fix the Integration pipeline. Of course there's a risk that I'm mistaken in which case such a PR would fail checks here.

[yann-achard-MS]

Thanks @markfields, I created #24745 (needs approval)