Revert "test(shared-matrix): add execution time performance benchmark tests for insert/remove rows, columns, and set cells" #24778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests f…" This reverts commit c7b2ee6.
github-actions
bot
added
area: build
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes from PR #24544 that introduced execution time performance benchmark tests for the SharedMatrix, following failing benchmarks in the pipeline.
- Removed "@fluidframework/matrix" from the performance benchmark parameters in the pipeline configuration.
- Deleted performance benchmark tests and their corresponding Mocha configuration files.
- Updated package.json and .gitignore to remove references to the benchmark tests.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/pipelines/test-perf-benchmarks.yml | Removed matrix package from the list of tests to run. |
| packages/dds/matrix/src/test/time/sharedMatrix.spec.ts | Deleted performance benchmark tests for the SharedMatrix. |
| packages/dds/matrix/src/test/time/.mocharc.cjs | Removed the Mocha configuration for execution time tests. |
| packages/dds/matrix/package.json | Removed the npm script for benchmark reporting. |
| packages/dds/matrix/.gitignore | Removed ignore entries specific to benchmark test outputs. |
Comments suppressed due to low confidence (4)
tools/pipelines/test-perf-benchmarks.yml:37
- Verify that removing '@fluidframework/matrix' from the benchmark parameters is aligned with the intended pipeline behavior.
- "@fluidframework/matrix"
packages/dds/matrix/src/test/time/sharedMatrix.spec.ts:1
- Confirm that the full removal of the SharedMatrix benchmark tests is acceptable per performance testing requirements and archive the tests if they may be needed in the future.
Entire file removed
packages/dds/matrix/package.json:100
- Ensure that any documentation or references relying on 'test:benchmark:report' are updated to reflect its removal.
"test:benchmark:report": "mocha --config src/test/time/.mocharc.cjs",
packages/dds/matrix/.gitignore:54
- [nitpick] Confirm that removing '.benchmarkOutput' from .gitignore is intentional and that it won’t affect any future artifact cleanup processes.
# Output folder for execution time profiling tests
.benchmarkOutput
jzaffiro
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #24544
Perf Benchmark Pipeline has been failing on the stage "Consolidate output files - @fluidframework/matrix" since #24544 was merged.
The PR changes seem related so I'm reverting as per OCE guidelines.